> We have tended to use reserved to mean dont use. Someone should > inspect the git history before trying to use a reserved value.. > When reserved are used in structures, usually for alignment, they are freely taken when a new field needs adding. Taking this logic to enums is bad. I agree that in enums it does raise a brow and it is evident this should be checked. Still, I think it is a better practice to give a more meaningful name and/or comment to differentiate. E.g.: IB_QP_XXX_DONT_USE /* Kept for backward compatibility only */ Thanks, Ram -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html