Re: How far back does rdma-core X supports the kernel Y?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/1/2017 8:00 PM, Jason Gunthorpe wrote:
          if (attr_mask & ~((1ULL << (IBV_QP_DEST_QPN + 1)) - 1))

The above rdma-core code is correct, look at verbs.h:
IBV_QP_DEST_QPN = 1 << 20,

Okay, then it should be

  if (attr_mask & ~(IB_QP_RATE_LIMIT - 1))


Why the library should support values that were never exposed in verbs.h ?

In addition, running over latest few kernel with your suggestion will fail any way [1] as those bits are marked as RESERVED in IB core and aren't really supported.

[1]
http://elixir.free-electrons.com/linux/v4.14-rc7/source/drivers/infiniband/core/uverbs_cmd.c#L2041
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux