On Sun, Oct 29, 2017 at 06:38:21PM +0200, idanb@xxxxxxxxxxxx wrote: > +static bool remote_invalidation = true; > +module_param(remote_invalidation, bool, 0444); > +MODULE_PARM_DESC(remote_invalidation, > + "request remote invalidation from subsystem (default: true)"); Please no module options. If your device has a performance anomaly that makes SEND_WITH_INVALIDATE slower than local invalidation, then we need to talk about having a new verbs flag for this situation so all the ULPs can avoid using SEND_WITH_INVALIDATE.. Sagi, is this really an apples to apples comparison? When I was talking with Chuck on NFS there were some various issues on that side that made the local invalidate run faster, but it wasn't actually working properly. Does nvme wait for the local invalidate to finish before moving on? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
