-----linux-rdma-owner@xxxxxxxxxxxxxxx wrote: -----
>To: Bernard Metzler <bmt@xxxxxxxxxxxxxx>
>From: Shiraz Saleem
>Sent by: linux-rdma-owner@xxxxxxxxxxxxxxx
>Date: 10/20/2017 02:49PM
>Cc: linux-rdma@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v2 06/13] SoftiWarp connection management
>
>On Fri, Oct 06, 2017 at 08:28:46AM -0400, Bernard Metzler wrote:
>> Signed-off-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx>
>> ---
>> drivers/infiniband/sw/siw/siw_cm.c | 2270
>++++++++++++++++++++++++++++++++++++
>> drivers/infiniband/sw/siw/siw_cm.h | 156 +++
>> 2 files changed, 2426 insertions(+)
>> create mode 100644 drivers/infiniband/sw/siw/siw_cm.c
>> create mode 100644 drivers/infiniband/sw/siw/siw_cm.h
>>
>> diff --git a/drivers/infiniband/sw/siw/siw_cm.c
>b/drivers/infiniband/sw/siw/siw_cm.c
>> new file mode 100644
>> index 000000000000..1527c9ddfed8
>> --- /dev/null
>> +++ b/drivers/infiniband/sw/siw/siw_cm.c
>
>> +static void siw_rtr_data_ready(struct sock *sk)
>> +{
>> + struct siw_cep *cep;
>> + struct siw_qp *qp = NULL;
>> + read_descriptor_t rd_desc;
>> +
>> + read_lock(&sk->sk_callback_lock);
>> +
>> + cep = sk_to_cep(sk);
>> + if (!cep) {
>> + WARN_ON(1);
>> + goto out;
>> + }
>> + qp = sk_to_qp(sk);
>> +
>> + memset(&rd_desc, 0, sizeof(rd_desc));
>> + rd_desc.arg.data = qp;
>> + rd_desc.count = 1;
>> +
>> + tcp_read_sock(sk, &rd_desc, siw_tcp_rx_data);
>> + /*
>> + * Check if first frame was successfully processed.
>> + * Signal connection full establishment if yes.
>> + * Failed data processing would have already scheduled
>> + * connection drop.
>> + */
>> + if (qp->rx_ctx.rx_suspend == 0 && qp->rx_ctx.rx_suspend == 0)
>> + siw_cm_upcall(cep, IW_CM_EVENT_ESTABLISHED, 0);
>
>Redundant condition in if. Also, its preferred to use
>!qp->rx_ctx.rx_suspend.
Oh yes, thank you!
>
>> + * siw_accept - Let SoftiWARP accept an RDMA connection request
>> + *
>> + * @id: New connection management id to be used for accepted
>> + * connection request
>> + * @params: Connection parameters provided by ULP for accepting
>connection
>> + *
>> + * Transition QP to RTS state, associate new CM id @id with
>accepted CEP
>> + * and get prepared for TCP input by installing socket callbacks.
>> + * Then send MPA Reply and generate the "connection established"
>event.
>> + * Socket callbacks must be installed before sending MPA Reply,
>because
>> + * the latter may cause a first RDMA message to arrive from the
>RDMA Initiator
>> + * side very quickly, at which time the socket callbacks must be
>ready.
>> + */
>> +int siw_accept(struct iw_cm_id *id, struct iw_cm_conn_param
>*params)
>> +{
>> + struct siw_dev *sdev = siw_dev_ofa2siw(id->device);
>> + struct siw_cep *cep = (struct siw_cep *)id->provider_data;
>> + struct siw_qp *qp;
>> + struct siw_qp_attrs qp_attrs;
>> + int rv, max_priv_data = MPA_MAX_PRIVDATA;
>> + bool wait_for_peer_rts = false;
>> +
>> + siw_cep_set_inuse(cep);
>> + siw_cep_put(cep);
>> +
>> + /* Free lingering inbound private data */
>> + if (cep->mpa.hdr.params.pd_len) {
>> + cep->mpa.hdr.params.pd_len = 0;
>> + kfree(cep->mpa.pdata);
>> + cep->mpa.pdata = NULL;
>> + }
>
>Can you not just check for cep->mpa.pdata?
Yes. I chose to do it that way to side-step a checkpatch warning
regarding 'kfree(NULL) is safe'.
>--
>To unsubscribe from this list: send the line "unsubscribe linux-rdma"
>in
>the body of a message to majordomo@xxxxxxxxxxxxxxx
>More majordomo info at
>https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_m
>ajordomo-2Dinfo.html&d=DwIBAg&c=jf_iaSHvJObTbx-siA1ZOg&r=2TaYXQ0T-r8Z
>O1PP1alNwU_QJcRRLfmYTAgd3QCvqSc&m=9skGbzeXQprZNNjOP17C90AQJw2UywxWNdd
>3Ho6nJ1U&s=9As1oQG0mz0YTgbxrGMbciEd0mdLDsmIvXa3R2kRYv8&e=
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
