On 10/24/2017 10:56 AM, Jason Gunthorpe wrote:
On Tue, Oct 24, 2017 at 10:02:23AM -0400, Dennis Dalessandro wrote:
Right, which doesn't say not to put it in a .c file. So I think the location
is OK for this. However, whether it even needs to be an inline function at
all in the first place is certainly a valid question. Let me chat with
Sebastian and double check, if it doesn't really need to be inlined we'll
send a v2.
The general thinking is that the compiler is much better at deciding
if something should be inlined or not. For the case of 'static' the
compiler will always inline it if it makes sense. 'static inline'
disables that heuristic and forces the compiler to always inline..
After talking with Sebastian, this doesn't need to be inlined after all.
I will send a v2.
-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
