On Tue, Oct 17, 2017 at 02:18:37AM -0600, Jason Gunthorpe wrote: > On Sun, Oct 15, 2017 at 08:47:46AM +0300, Yuval Shaia wrote: > > > > > As far as I understand ipoib_netlink.c, ipoib_new_child_link() already > > > > implements it and it is supported in "ip". > > > > > > Oh right: > > > > > > ip link add DEVICE name NAME type ipoib [ pkey PKEY ] [mode MODE ] > > > > So with this interface we can entirely remove the sysfs interface to create > > child, right? > > Yes, we should add a deprecation one shot printk to the kernel for the > sysfs interface to encourage people to use ip Please don't do that, it won't help for anyone, and especially for the people who didn't hear about "ip" in 2017. IPoIB netlink doesn't support enhanced IPoIB device because child device in netlink code was not allocated with rdma_alloc_netdev call as it was done for other flows. Thanks > > Jason
Attachment:
signature.asc
Description: PGP signature
