On 10/12/17 11:05, Dennis Dalessandro wrote:
If we were using the staging tree still, I'd say it's in good enough
shape to send there and let it get hacked on, but we aren't going down
that road in this subsystem again I don't think. So the bar is a little
higher I for getting in to mainline.
The most important aspect that needs to be addressed is probably the
user space interface for the siw driver. We don't want users to have to
deal with multiple incompatible versions of a user space interface so we
must get the user space interface right before this driver goes upstream.
> You also have a large number of debugging prints. While it's nice for
> development and can be turned off, I think alot of those are
> unnecessary. The RDMA subsystem on the whole needs a better strategy
> for dealing with debugging and logging, we just aren't there yet.
Unless someone has a better proposal I think the dprint() macro
definition should be removed and all dprint() invocations that we want
to keep should be changed into pr_debug() calls. The dynamic debug
mechanism is more powerful than what the dprint() macro implements.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
