> -----Original Message----- > From: Bart Van Assche [mailto:Bart.VanAssche@xxxxxxx] > Sent: Friday, October 06, 2017 10:32 AM > To: bmt@xxxxxxxxxxxxxx; Parav Pandit <parav@xxxxxxxxxxxx>; linux- > rdma@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 06/13] SoftiWarp connection management > > On Fri, 2017-10-06 at 14:59 +0000, Parav Pandit wrote: > > > + BUG_ON(!cep); > > > > Do you need BUG_ON or can be converted to WARN__ and return? > > Hello Bernard and Parav, > > Using BUG_ON() in new code is considered unacceptable. See e.g. Linus > Torvalds, Yes. However checkpatch.pl shows that as warning instead of error. It may be worth to change to report that as an error to reflect what Linus mentioned in [1]. That allows to catch it even before patch gets posted. [1] https://lkml.org/lkml/2016/10/4/1 ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
