Re: [PATCH rdma-core] libhns: Update the size and member order of hns_roce_create_qp structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 30, 2017 at 07:05:15PM +0300, Leon Romanovsky wrote:
> On Sat, Sep 30, 2017 at 09:45:18AM -0600, Jason Gunthorpe wrote:
> > On Sat, Sep 30, 2017 at 04:51:17PM +0800, Lijun Ou wrote:
> > > In order to keep the size and member order with the
> > > hns_roce_ib_create_qp sturcture of the kernel driver,
> > > it need to update hns_roce_create_qp's structure
> > > members. Otherwise, it will run fail.
> >
> > What?
> >
> > Did you break the uapi? What kernel patch does this match with?
> >
> > Generally structs in the u_abi.h headers cannot be changed like this.
>
> Jason,
>
> It was my suggestion to change rdma-core, because before they tried to
> change kernel.
>
> https://patchwork.kernel.org/patch/9975329/
>

And according to the git log on providers/hns/hns_roce_u_abi.h and
include/uapi/rdma/hns-abi.h, it never worked.

>
> >
> > Jason
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html


Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux