Re: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 27, 2017 at 07:53:39PM +0300, Leon Romanovsky wrote:
> On Wed, Sep 27, 2017 at 04:18:50PM +0000, Kalderon, Michal wrote:
> > From: Doug Ledford <dledford@xxxxxxxxxx>
> > Sent: Wednesday, September 27, 2017 4:27 PM
> >
> > >On Wed, 2017-09-20 at 08:39 +0300, Michal Kalderon wrote:
> > >> Initialize the rdma_type (iWARP or RoCE) which is set according to
> > >> device configuration in qed.
> > >>
> > >> Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an iWARP
> > >> device")
> > >>
> > >> Signed-off-by: Michal Kalderon <Michal.Kalderon@xxxxxxxxxx>
> > >> Signed-off-by: Ariel Elior <Ariel.Elior@xxxxxxxxxx>
> > >>
> > >> ---
> > >> This patch applies cleanly on k.o/for-next-merged
> > >>
> > >> Changes from V0:
> > >> - Added Fixes in commit comment.
> > >
> > >Sorry, I was wrong in my email to the previous posting of this patch.
> > >I had pulled this v1 patch from patchworks, not the original patch, and
> > >so the Fixes: line was yours.  Patchworks did not add the Fixes: line
> > >to the v0 patch when I downloaded it just now.
> >
> > >That being said, I still can't build with this patch ;-)
> > Are you building against the rdma-next branch ?
> > The patch requires the iWARP series, originally this was tested against for-next-merged,
> > what's the error you're getting ?
>
> On rdma-next:
> drivers/infiniband/hw/qedr/main.c: In function ‘qedr_add’:
> drivers/infiniband/hw/qedr/main.c:780:7: error: ‘struct qedr_dev’ has no member named ‘rdma_type’; did you mean ‘rdma_ctx’?
>   dev->rdma_type = dev_info.rdma_type;
>        ^~~~~~~~~
>        rdma_ctx
> make[4]: *** [scripts/Makefile.build:311: drivers/infiniband/hw/qedr/main.o] Error 1

My config:

➜  linux-rdma git:(rdma-next) grep QED .config
CONFIG_QED=m
CONFIG_QED_LL2=y
CONFIG_QED_SRIOV=y
CONFIG_QEDE=m
CONFIG_QED_RDMA=y
CONFIG_INFINIBAND_QEDR=m
>
>
> >
> > thanks,
> > Michal
> >
> > --
> > Doug Ledford <dledford@xxxxxxxxxx>
> >     GPG KeyID: B826A3330E572FDD
> >     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD
> >


Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux