Hi Doug, Here is a set of patches that does some code rework to our IOCTL handling from Mike. I have bundled it as a separate series to make handling review feedback easier. The HFI1 ioctl() function is long and complex. To reduce that complexity the following patch set refactors each IOCTL into a common pattern, and where necessary calls an associated function to handle the specific IOCTL. Patches can can also be found in my GitHub repo at: https://github.com/ddalessa/kernel/tree/for-4.15 --- Michael J. Ruhl (9): IB/hfi1: Refactor assign_ctxt() IOCTL IB/hfi1: Refactor get_ctxt_info IB/hfi1: Fix parenthesis alignment issues IB/hfi1: Refactor get_base_info IB/hfi1: Refactor hfi_user_exp_rcv_setup() IOCTL IB/hfi1: Refactor hfi_user_exp_rcv_clear() IOCTLs IB/hfi1: Refactor hfi_user_exp_rcv_invalid() IOCTLs IB/hfi1: Refactor get_user() IOCTLs IB/hfi1: Refactor reset_ctxt() IOCTL drivers/infiniband/hw/hfi1/file_ops.c | 463 +++++++++++++++++------------ drivers/infiniband/hw/hfi1/user_exp_rcv.c | 3 2 files changed, 272 insertions(+), 194 deletions(-) -- -Denny -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html