Re: [PATCH rdma-rc 1/7] IB/core: Fix typo in the name of the tag-matching cap struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mon, Sep 25, 2017 at 05:45:38AM CEST, leon@xxxxxxxxxx wrote:
>On Sun, Sep 24, 2017 at 10:18:48PM +0200, Jiri Pirko wrote:
>> Sun, Sep 24, 2017 at 08:46:29PM CEST, leon@xxxxxxxxxx wrote:
>> >From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
>> >
>> >The tag matching functionality is implemented by mlx5 driver
>> >by extending XRQ, however this internal kernel information was
>> >exposed to user space applications with *xrq* name instead of *tm*.
>> >
>> >This patch renames *xrq* to *tm* to handle that.
>> >
>> >Fixes: 8d50505ada72 ("IB/uverbs: Expose XRQ capabilities")
>> >Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
>> >Reviewed-by: Yishai Hadas <yishaih@xxxxxxxxxxxx>
>>
>> [...]
>>
>> >diff --git a/include/uapi/rdma/ib_user_verbs.h b/include/uapi/rdma/ib_user_verbs.h
>> >index 9a0b6479fe0c..d4e0b53bfc75 100644
>> >--- a/include/uapi/rdma/ib_user_verbs.h
>> >+++ b/include/uapi/rdma/ib_user_verbs.h
>> >@@ -261,7 +261,7 @@ struct ib_uverbs_ex_query_device_resp {
>> > 	struct ib_uverbs_rss_caps rss_caps;
>> > 	__u32  max_wq_type_rq;
>> > 	__u32 raw_packet_caps;
>> >-	struct ib_uverbs_tm_caps xrq_caps;
>> >+	struct ib_uverbs_tm_caps tm_caps;
>>
>> Breaks UAPI?
>
>Not really, this UAPI was introduced in latest merge window and
>wasn't exposed to users yet. The -rcX rally is the time where such
>fixes are supposed to happen.

Would be nice to mention this in the patch description. Perhaps under "---".

>
>Thanks
>
>>


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux