For qedr: Signed-off-by: Ram Amrani <Ram.Amrani@xxxxxxxxxx> See the following question though, not directly related to the patch: > static struct verbs_device *qedr_device_alloc(struct verbs_sysfs_dev *sysfs_dev) > { > struct qelr_device *dev; > @@ -269,7 +238,7 @@ static const struct verbs_device_ops qelr_dev_ops = { > .name = "qelr", Should this be the driver name or the library name? The driver name is qedr and the library name is libqedr. It is usually abbreviated to qelr. I reckon that this should be the driver name (otherwise auto-load will fail?!). > .match_min_abi_version = QELR_ABI_VERSION, > .match_max_abi_version = QELR_ABI_VERSION, > - .match_device = qedr_device_match, > + .match_table = hca_table, > .alloc_device = qedr_device_alloc, > .uninit_device = qelr_uninit_device, > .alloc_context = qelr_alloc_context, Following the above, and still not directly related to the patch, is usage of both names. I'll fix this after your submission to qelr_... Thanks, Ram -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html