Re: [PATCH for-next 00/20] RDMA/hns: Add hip08 RoCE driver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 14, 2017 at 03:45:53PM +0800, Wei Hu (Xavier) wrote:
>
>
> On 2017/9/14 1:55, Leon Romanovsky wrote:
> > On Wed, Aug 30, 2017 at 05:22:58PM +0800, Wei Hu (Xavier) wrote:
> > > This patchset adds support for the HiSilicon RoCE engine in the hip08
> > > SoC.
> > >
> > > The driver is refactored so it can support both platform and pci device.
> > > And hip08 RoCE engine is a pci device, hip06 RoCE engine is a platform
> > > device.
> > >
> > > New hardware layer file hns_roce_hw_v2.c is added for hw v2 support,
> > > which also includes pci device probing and initialization.
> > >
> > > Common functionality is still in hns-roce driver, along with device
> > > initialization.
> > >
> > > This patchset depends on hns3 NIC driver which had been accepted by David,
> > > and is based on for-next branch of the repo:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git
> > >
> > > Shaobo Xu (3):
> > >    RDMA/hns: Add the interfaces to support multi hop addressing for the
> > >      contexts in hip08
> > >    RDMA/hns: Update the interfaces for MTT/CQE multi hop addressing in
> > >      hip08
> > >    RDMA/hns: Split CQE from MTT in hip08
> > >
> > > Wei Hu (Xavier) (17):
> > >    RDMA/hns: Split hw v1 driver from hns roce driver
> > >    RDMA/hns: Move priv in order to add multiple hns_roce support
> > >    RDMA/hns: Initialize the PCI device for hip08 RoCE
> > >    RDMA/hns: Modify assignment device variable to support both PCI device
> > >      and platform device
> > >    RDMA/hns: Add command queue support for hip08 RoCE driver
> > >    RDMA/hns: Add profile support for hip08 driver
> > >    RDMA/hns: Add mailbox's implementation for hip08 RoCE driver
> > >    RDMA/hns: Configure BT BA and BT attribute for the contexts in hip08
> > >    RDMA/hns: Support multi hop addressing for PBL in hip08
> > >    RDMA/hns: Configure mac&gid and user access region for hip08 RoCE
> > >      driver
> > >    RDMA/hns: Add CQ operations support for hip08 RoCE driver
> > >    RDMA/hns: Add QP operations support for hip08 SoC
> > >    RDMA/hns: Add support for processing send wr and receive wr
> > >    RDMA/hns: Configure the MTPT in hip08
> > >    RDMA/hns: Add releasing resource operation in error branch
> > >    RDMA/hns: Replace condition statement using hardware version
> > >      information
> > >    RDMA/hns: Fix inconsistent warning
> > >
> > >   drivers/infiniband/hw/hns/Kconfig           |   25 +-
> > >   drivers/infiniband/hw/hns/Makefile          |    8 +-
> > >   drivers/infiniband/hw/hns/hns_roce_ah.c     |    2 +-
> > >   drivers/infiniband/hw/hns/hns_roce_alloc.c  |    8 +-
> > >   drivers/infiniband/hw/hns/hns_roce_cmd.c    |  107 +-
> > >   drivers/infiniband/hw/hns/hns_roce_cmd.h    |   50 +
> > >   drivers/infiniband/hw/hns/hns_roce_common.h |   23 +
> > >   drivers/infiniband/hw/hns/hns_roce_cq.c     |   72 +-
> > >   drivers/infiniband/hw/hns/hns_roce_device.h |   98 +-
> > >   drivers/infiniband/hw/hns/hns_roce_hem.c    |  699 +++++-
> > >   drivers/infiniband/hw/hns/hns_roce_hem.h    |   32 +-
> > >   drivers/infiniband/hw/hns/hns_roce_hw_v1.c  |  401 +++-
> > >   drivers/infiniband/hw/hns/hns_roce_hw_v1.h  |    5 +
> > >   drivers/infiniband/hw/hns/hns_roce_hw_v2.c  | 3128 +++++++++++++++++++++++++++
> > >   drivers/infiniband/hw/hns/hns_roce_hw_v2.h  | 1165 ++++++++++
> > >   drivers/infiniband/hw/hns/hns_roce_main.c   |  324 +--
> > >   drivers/infiniband/hw/hns/hns_roce_mr.c     |  513 ++++-
> > >   drivers/infiniband/hw/hns/hns_roce_pd.c     |   20 +-
> > >   drivers/infiniband/hw/hns/hns_roce_qp.c     |  179 +-
> > >   19 files changed, 6318 insertions(+), 541 deletions(-)
> > >   create mode 100644 drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> > >   create mode 100644 drivers/infiniband/hw/hns/hns_roce_hw_v2.h
> > >
> > > --
> > As far as I can see, it is ready to be merged.
> >
> > Thanks,
> Hi, Leon
>     Thanks for your comments.
>
>     And about the comment on the No.11 patch of this patchset,
>     Which option we should do?  Can you give us some suggestions?
>     1. send PATCH V2 to fix it.
>     2. After this patchset will be merged, send a new patch to fix it.

In your case (20 patches, many LOCs), it will be enough to send a followup patch
to remove it, however you don't need to wait till it is merged and you
can send it now with note placed under "---" markings that it is based
on this series.

Thanks

>
>     The link about the comment:
> https://www.spinics.net/lists/linux-rdma/msg54392.html
>
>     Regards
> Wei Hu
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux