Re: [PATCH] libmlx5: add support for the s390x platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 09/06/2017 05:22 PM, Jason Gunthorpe wrote:
On Wed, Sep 06, 2017 at 05:15:00PM +0300, Leon Romanovsky wrote:
On Wed, Sep 06, 2017 at 03:36:20PM +0200, Kittipon Meesompop wrote:
Since s390x platform requires execution of privileged CPU instructions
to work with PCI I/O memory, the PCI I/O memory cannot be directly
accessed from the userspace programs via the mapped memory areas.

This patch is created against libmlx5-1.2.1 and contains the changes to
the libmlx5 userspace Mellanox device driver library required to provide
support for the DAPL API on the s390x platform. The original code that
directly used mapped memory areas to access the PCI I/O memory of the
Mellanox networking device is replaced with the new system call
invocation for writing the data to mapped memory areas. The functions
for reading and writing are added analogously to libmlx4.

libmlx4 comparison to:
         commit f5c26f8762135f629c8cbe73d808e3029f07b176
         Author: Alexey Ishchuk <aishchuk@xxxxxxxxxxxxxxxxxx>
         Date:   Wed Nov 19 11:17:19 2014 +0100

Signed-off-by: Kittipon Meesompop <kmeesomp@xxxxxxxxxxxxxxxxxx>

Thank you for doing it. I afraid that you sent this patch to a wrong
mailing list. I don't know exactly where you should sent it, but all
new development for last ~12 months of RDMA user space stack is done
against rdma-core [1].
.. and I already did s390 support for mlx5 drivers in rdma-core, you
should test it.

Jason
Thanks for your info; we should have listened better to linux-rdma. That means my sent libmlx5 patch is not needed anymore. I now have run dapltest with your rdma-core provided libraries libmlx4.so,1.0.15 and libmlx5.so.1.2.15 on an IBM internally built driver for s390. libmlx5 results with and without vlan interfaces look good, libmlx4 results look good for non-vlan interfaces. Analysis of the libmlx4 failure for vlan-interfaces is ongoing; it might just be a driver issue.

Kittipon

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux