On Tue, 2017-09-05 at 11:29 +0300, Yuval Shaia wrote: > On Tue, Sep 05, 2017 at 04:16:51AM +0000, Bart Van Assche wrote: > > On Tue, 2017-09-05 at 07:08 +0300, Leon Romanovsky wrote: > > > Why do we need to be dependent on CONFIG_BROKEN? > > > Is it still valid for IB stack? > > > > Hello Leon, > > > > As far as I know "&& BROKEN" makes sense but "|| BROKEN" not. The "|| BROKEN" > > part was introduced through the following patch: > > Can you elaborate more on (1) why BROKEN is needed and (2) why "&&" make > sense and "||" not? Hello Yuval, Sorry if I was not clear enough. What I meant is that for broken drivers "&& BROKEN" should be used instead of "|| BROKEN". My opinion is that "|| BROKEN" is neither needed nor that it makes sense for InfiniBand. Bart.��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f