On Tue, Sep 05, 2017 at 04:16:51AM +0000, Bart Van Assche wrote: > On Tue, 2017-09-05 at 07:08 +0300, Leon Romanovsky wrote: > > Why do we need to be dependent on CONFIG_BROKEN? > > Is it still valid for IB stack? > > Hello Leon, Thanks Bart, It was 12 years ago and it is worth to try to build without BROKEN at all. > > As far as I know "&& BROKEN" makes sense but "|| BROKEN" not. The "|| BROKEN" > part was introduced through the following patch: > > > From a2b2f45be7e9138bde7fcba3b8e9257fea04d087 Mon Sep 17 00:00:00 2001 > From: Al Viro <viro@xxxxxxxxxxxxxxxx> > Date: Tue, 23 Aug 2005 22:45:41 +0100 > Subject: [PATCH] [PATCH] Kconfig fix (infiniband and PCI) > > infiniband uses PCI helpers all over the place (including the core parts) and > won't build without PCI. > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx> > --- > drivers/infiniband/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig > index 79c8e2dd9c33..32cdfb30e9b4 100644 > --- a/drivers/infiniband/Kconfig > +++ b/drivers/infiniband/Kconfig > @@ -1,6 +1,7 @@ > menu "InfiniBand support" > > config INFINIBAND > + depends on PCI || BROKEN > tristate "InfiniBand support" > ---help--- > Core support for InfiniBand (IB). Make sure to also select
Attachment:
signature.asc
Description: PGP signature
