> -----Original Message----- > From: Pavel Shilovsky [mailto:piastryyy@xxxxxxxxx] > Sent: Tuesday, August 29, 2017 5:50 PM > To: Long Li <longli@xxxxxxxxxxxxx> > Cc: Steve French <sfrench@xxxxxxxxx>; linux-cifs <linux- > cifs@xxxxxxxxxxxxxxx>; samba-technical <samba-technical@xxxxxxxxxxxxxxx>; > Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; linux- > rdma@xxxxxxxxxxxxxxx; Christoph Hellwig <hch@xxxxxxxxxxxxx>; Tom Talpey > <ttalpey@xxxxxxxxxxxxx>; Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>; > Long Li <longli@xxxxxxxxxxxxx> > Subject: Re: [Patch v3 12/19] CIFS: SMBD: Fix the definition for > SMB2_CHANNEL_RDMA_V1_INVALIDATE > > 2017-08-29 12:29 GMT-07:00 Long Li <longli@xxxxxxxxxxxxxxxxxxxxxx>: > > From: Long Li <longli@xxxxxxxxxxxxx> > > > > The channel value for requesting server remote invalidating local > > memory registration should be 0x00000002 > > > > Signed-off-by: Long Li <longli@xxxxxxxxxxxxx> > > --- > > fs/cifs/smb2pdu.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/cifs/smb2pdu.h b/fs/cifs/smb2pdu.h index > > 18700fd..0417a36 100644 > > --- a/fs/cifs/smb2pdu.h > > +++ b/fs/cifs/smb2pdu.h > > @@ -832,7 +832,7 @@ struct smb2_flush_rsp { > > /* Channel field for read and write: exactly one of following flags can be > set*/ > > #define SMB2_CHANNEL_NONE 0x00000000 > > #define SMB2_CHANNEL_RDMA_V1 0x00000001 /* SMB3 or later */ > > -#define SMB2_CHANNEL_RDMA_V1_INVALIDATE 0x00000001 /* SMB3.02 > or > > later */ > > +#define SMB2_CHANNEL_RDMA_V1_INVALIDATE 0x00000002 /* > SMB3.02 or > > +later */ > > > > /* SMB2 read request without RFC1001 length at the beginning */ > > struct smb2_read_plain_req { > > -- > > 2.7.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-cifs" > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More > majordomo > > info at > > > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.k > > ernel.org%2Fmajordomo- > info.html&data=02%7C01%7Clongli%40microsoft.com% > > > 7C9a11066a2c3b402da09f08d4ef411927%7C72f988bf86f141af91ab2d7cd011d > b47% > > > 7C1%7C0%7C636396510253376659&sdata=0fLwHcdbOLSOsbKj5PZ2yrJap%2B > N0ZB%2B > > TGbFimPMqcx4%3D&reserved=0 > > If this is a bug in the existing code, this patch should go at the very beginning > of the series. Okay, I will reorder the patch. > > -- > Best regards, > Pavel Shilovsky ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
