> -----Original Message----- > From: Pavel Shilovsky [mailto:piastryyy@xxxxxxxxx] > Sent: Tuesday, August 29, 2017 4:12 PM > To: Long Li <longli@xxxxxxxxxxxxx> > Cc: Steve French <sfrench@xxxxxxxxx>; linux-cifs <linux- > cifs@xxxxxxxxxxxxxxx>; samba-technical <samba-technical@xxxxxxxxxxxxxxx>; > Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; linux- > rdma@xxxxxxxxxxxxxxx; Christoph Hellwig <hch@xxxxxxxxxxxxx>; Tom Talpey > <ttalpey@xxxxxxxxxxxxx>; Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>; > Long Li <longli@xxxxxxxxxxxxx> > Subject: Re: [Patch v3 04/19] CIFS: SMBD: Add SMBDirect transport to SMB > connection and Makefile > > 2017-08-29 12:29 GMT-07:00 Long Li <longli@xxxxxxxxxxxxxxxxxxxxxx>: > > From: Long Li <longli@xxxxxxxxxxxxx> > > > > Add SMBDirect as an optional connection to the SMB session structure in > CIFS. > > When SMB session is connected through SMBDirect, upper layer uses this > > connection to carry payloads. > > > > With the transport code hooked up to upper layer, add SMBDirect code > > to Makefile. > > > > Signed-off-by: Long Li <longli@xxxxxxxxxxxxx> > > --- > > fs/cifs/Makefile | 2 +- > > fs/cifs/cifsglob.h | 2 ++ > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/fs/cifs/Makefile b/fs/cifs/Makefile index > > eed7eb0..6bb9863 100644 > > --- a/fs/cifs/Makefile > > +++ b/fs/cifs/Makefile > > @@ -18,4 +18,4 @@ cifs-$(CONFIG_CIFS_DFS_UPCALL) += dns_resolve.o > > cifs_dfs_ref.o > > cifs-$(CONFIG_CIFS_FSCACHE) += fscache.o cache.o > > > > cifs-$(CONFIG_CIFS_SMB2) += smb2ops.o smb2maperror.o > smb2transport.o \ > > - smb2misc.o smb2pdu.o smb2inode.o smb2file.o > > + smb2misc.o smb2pdu.o smb2inode.o > > + smb2file.o smbdirect.o > > diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h index > > 703c2fb..dc5404d 100644 > > --- a/fs/cifs/cifsglob.h > > +++ b/fs/cifs/cifsglob.h > > @@ -652,6 +652,8 @@ struct TCP_Server_Info { > > bool large_buf; /* is current buffer large? */ > > /* use SMBD connection instead of socket */ > > bool rdma; > > + /* point to the SMBD connection if RDMA is used instead of socket */ > > + struct smbd_connection *smbd_conn; > > struct delayed_work echo; /* echo ping workqueue job */ > > char *smallbuf; /* pointer to current "small" buffer */ > > char *bigbuf; /* pointer to current "big" buffer */ > > -- > > 2.7.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-cifs" > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More > majordomo > > info at > > > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.k > > ernel.org%2Fmajordomo- > info.html&data=02%7C01%7Clongli%40microsoft.com% > > > 7C74a459a67c6440f88d4308d4ef3358c5%7C72f988bf86f141af91ab2d7cd011db > 47% > > > 7C1%7C0%7C636396451192818334&sdata=nIFmV5wvnL1xMm6tCnfdAgLMt% > 2BFKJU6oh > > hNhEXO8ZJs%3D&reserved=0 > > It is better to split the current patch into 2 and merge the Makefile part to #3 > and cifsglob.h part to #5. Sure, will make the change. > > -- > Best regards, > Pavel Shilovsky ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f