Le 28/08/2017 à 17:31, Jason Gunthorpe a écrit :
> On Mon, Aug 28, 2017 at 05:23:25PM +0200, Nicolas Morey-Chaisemartin wrote:
>> Le 28/08/2017 ?? 17:16, Jason Gunthorpe a ??crit??:
>>> On Mon, Aug 28, 2017 at 05:05:33PM +0200, Nicolas Morey-Chaisemartin wrote:
>>>
>>>> -sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
>>>> -chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
>>> You probably still need something dracut related.
>>>
>>> At a minimum you have to address the problem we saw in Debian: mlx5
>>> and mlx4 need to have their rdma modules include in the initrd if
>>> their core modules are included. (eg anything request_module'd from
>>> the initrd must be present)
>>>
>>> You may need to do more if you intend to support boot over ipoib, srp,
>>> nfs-rdma, etc - I think the RH scripts aim to support.
>> These were in your mail so I assumed they could be dropped :)
>> I'll keep the dracut stuff then.
> I was not careful about what I quoted.. Just stuff in that overall area.
>
> The existing dracut script seems to assume other things, so you may
> need a new dracut script. If it is totally general then it can live in
> kernel-boot..
>
> You should also consider if you need the udev triggers, I don't know
> what suse policy is. Look in debian/rdma-core.postinst and others.
>
> Adding them allows the udev rules to trigger on package install and
> makes everything start working without a reboot.
I looked around to all the scripts and I'm going some time to go through all these and decide which we need and which we don't.
Some of those were all upstreamed at once and I'm not sure what the bug they were fixing and if it is still needed.
I contacted Doug on the side. It would make sense to work with Red Hat to migrate to the udev system (vs rdma.service) and "cleanup" those scripts so they can be shared more easily.
This also means this won't be done before v15 is out. We should keep SUSE spec as is (it works) and work on the cleanup for v16.
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
