Re: [PATCH rdma-core 0/3] Improve symbol version support in ibverbs & providers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 24, 2017 at 04:00:26PM -0600, Jason Gunthorpe wrote:
> This changes the macros used to delcare symbol versions to something that can
> really safely support static libraries by removing all traces of symbol versioning
> when the static library is built.
>
> This also addresses the uclib problem and solves the need for ugly function prototypes
> in a different way, using a fairly ugly macro to generate all the needed prototypes
> and versions for the different operating modes instead.
>
>

Thanks Jason for doing it.

It looks very good, but I would like to wait till tomorrow, so Yishai
(he is OOO today) will take second look on it and ensure that I didn't
miss anything important.

Also I think that after this series, it will be safe to change default
of "-DENABLE_STATIC" to be on.

Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>

Thanks

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux