On Thu, 2017-08-24 at 21:11 +0530, Himanshu Jha wrote: > Use ether_addr_copy to copy an ethernet address of size ETH_ALEN > instead of memcpy. [] diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c [] > @@ -798,7 +798,7 @@ int rdma_addr_find_l2_eth_by_grh(const union ib_gid *sgid, > if (ret) > return ret; > > - memcpy(dmac, dev_addr.dst_dev_addr, ETH_ALEN); > + ether_addr_copy(dmac, dev_addr.dst_dev_addr); > dev = dev_get_by_index(&init_net, dev_addr.bound_dev_if); > if (!dev) > return -ENODEV; > @@ -831,7 +831,7 @@ int rdma_addr_find_smac_by_sgid(union ib_gid *sgid, u8 *smac, u16 *vlan_id) > if (ret) > return ret; > > - memcpy(smac, dev_addr.src_dev_addr, ETH_ALEN); > + ether_addr_copy(smac, dev_addr.src_dev_addr); > return ret; > } > EXPORT_SYMBOL(rdma_addr_find_smac_by_sgid); Both dmac and smac are function arguments. What guarantees these to be aligned properly? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
