On 8/23/17, 11:29 AM, "Leon Romanovsky" <leon@xxxxxxxxxx> wrote: >On Wed, Aug 23, 2017 at 02:59:52PM +0000, Boyer, Andrew wrote: >> >> >> On 8/15/17, 5:14 AM, "linux-rdma-owner@xxxxxxxxxxxxxxx on behalf of Leon >> Romanovsky" <linux-rdma-owner@xxxxxxxxxxxxxxx on behalf of >> leon@xxxxxxxxxx> wrote: >> >> >From: Leon Romanovsky <leonro@xxxxxxxxxxxx> >> > >> >There are new defines to express the physical state of the link, so >> >let's reuse them instead hard-coded values. >> > >> >Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> >> >--- >> >diff --git a/drivers/infiniband/sw/rxe/rxe_param.h >> >b/drivers/infiniband/sw/rxe/rxe_param.h >> >index 1b596fbbe251..475767262102 100644 >> >--- a/drivers/infiniband/sw/rxe/rxe_param.h >> >+++ b/drivers/infiniband/sw/rxe/rxe_param.h >> >@@ -157,7 +157,7 @@ enum rxe_port_param { >> > RXE_PORT_ACTIVE_WIDTH = IB_WIDTH_1X, >> > RXE_PORT_ACTIVE_SPEED = 1, >> > RXE_PORT_PKEY_TBL_LEN = 64, >> >- RXE_PORT_PHYS_STATE = 2, >> >+ RXE_PORT_PHYS_STATE = RDMA_LINK_PHYS_STATE_POLLING, >> > RXE_PORT_SUBNET_PREFIX = 0xfe80000000000000ULL, >> > }; >> >> You can also remove IB_PHYS_STATE_* from rxe.h and the places where >> they¹re used. > >At the end, I found the way to avoid the whole this series. >This series is dropped. > >Thanks Would you object if I added similar / matching defines in ib_verbs.h? The phys_state field allows userspace to distinguish between a link that’s down and a link that’s turned off, but only a few drivers seem to support it. -Andrew ÿ淸º{.nÇ+돴윯돪†+%듚ÿ깁負¥Šwÿº{.nÇ+돴¥Š{깸·fk悖¶썳變}©옽Æ zÚ&j:+v돣?®w?듺2듷솳鈺Ú&¢)傘«a뛴ÿÿ鎬z요z받쀺+껠šŽ듶¢jÿŠw療f