On Wed, Aug 23, 2017 at 03:13:38PM +0300, Yishai Hadas wrote: > On 8/22/2017 7:30 PM, Jason Gunthorpe wrote: > >On Tue, Aug 22, 2017 at 11:36:42AM +0300, Yishai Hadas wrote: > >>On 8/21/2017 6:22 PM, Jason Gunthorpe wrote: > >>>Is there existing code out there that uses cq_out->uar and works > >>>properly today? Yes or No? > >> > >>No, only this fix enables that to work properly. > > >Particularly since a patch to do this with proper compatibility > >exists, and there is no reason at all to take a shortcut. > > We are not looking for a shortcut but for a solution that will match > majority users if not all. It is a short cut. > Changing the symbol version for this API will cause that applications that > will be linked against this version won't be able to run at all on > previous Then provide the compat symbol too, as I said in the first place, easy to do. There is no excuse here. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html