On Mon, Aug 21, 2017 at 6:57 PM, Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Aug 21, 2017 at 03:03:10PM +0300, Leon Romanovsky wrote: >> On Mon, Aug 21, 2017 at 12:24:14PM +0300, Yigal Korman wrote: >> > Hi, >> > Has anyone noticed that installing rdma-core (or older >> > librdmacm-devel) package and then installing kernel headers manually >> > (make headers_install) removes the librdmacm headers? >> > I actually see it in the make output: >> > >> > make INSTALL_HDR_PATH=/usr headers_install >> > CHK include/generated/uapi/linux/version.h >> > REMOVE rdma_cma_abi.h rdma_verbs.h rdma_cma.h rsocket.h >> > >> > Am I doing something wrong? >> > Sounds like the kernel rdma headers and librdmacm headers shouldn't >> > sit in the same directory... >> >> It looks like this behavior (removal of header files) was from the beginning of git era. >> ➜ linux-rdma git:(rdma-next) ✗ git co -b tmp v2.6.34.8 >> ➜ linux-rdma git:(tmp) ✗ cp ~/src/rdma-core/librdmacm/rdma_verbs.h /tmp/h/include/rdma/ && make INSTALL_HDR_PATH=/tmp/h headers_install | grep REMOVE >> REMOVE rdma_verbs.h > > The user space files have also been sharing the directory with the > kernel files since the start.. Not sure why, but I don't think we can > change it now. > > Maybe someone can patch the kernel to exempt rdma/ from the removal > process? Yeah, that would be a good possible fix for this. I had a quick look at the kernel headers install scripts and didn't see any mechanism for this, but I might've missed it. I'm adding linux-kbuild mailing list here, maybe someone there can help? Thanks > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html