Hi Leon, > -----Original Message----- > From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma- > owner@xxxxxxxxxxxxxxx] On Behalf Of Leon Romanovsky > Sent: Monday, August 21, 2017 3:48 PM > To: Salil Mehta > Cc: Andrew Lunn; davem@xxxxxxxxxxxxx; Zhuangyuzeng (Yisen); lipeng (Y); > mehta.salil.lnk@xxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Linuxarm > Subject: Re: [PATCH V3 net-next] net: hns3: Add support to change MTU > in HNS3 hardware > > On Mon, Aug 21, 2017 at 02:32:40PM +0000, Salil Mehta wrote: > > Hi Andrew, > > > > > -----Original Message----- > > > From: Andrew Lunn [mailto:andrew@xxxxxxx] > > > Sent: Monday, August 21, 2017 3:30 PM > > > To: Salil Mehta > > > Cc: davem@xxxxxxxxxxxxx; Zhuangyuzeng (Yisen); lipeng (Y); > > > mehta.salil.lnk@xxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- > > > kernel@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Linuxarm > > > Subject: Re: [PATCH V3 net-next] net: hns3: Add support to change > MTU > > > in HNS3 hardware > > > > > > On Mon, Aug 21, 2017 at 11:12:23AM +0100, Salil Mehta wrote: > > > > This patch adds the following support to the HNS3 driver: > > > > 1. Support to change the Maximum Transmission Unit of a > > > > of a port in the HNS NIC hardware. > > > > 2. Initializes the supported MTU range for the netdevice. > > > > > > > > Signed-off-by: lipeng <lipeng321@xxxxxxxxxx> > > > > Signed-off-by: Salil Mehta <salil.mehta@xxxxxxxxxx> > > > > > > Hi Salil > > > > > > Apart from Leon comments. > > > > > > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> > > > > > > Andrew > > > > I will incorporate Leon's comment and float V4 patch today. Thanks! > > > > Salil, > > I had two comment there and not one. Please don't miss it :) Sure, I should admit that I missed one comment while I replied to the mail but later realized that, and incorporated it while I floated the V4 patch. Having a bad day of misses...phew! Again, thanks Andrew & Leon for helping me out in reviewing this patch. Best regards Salil > > Thanks > > > Best regards > > Salil > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" > in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html