Hi Andrew, > > -----Original Message----- > > From: Andrew Lunn [mailto:andrew@xxxxxxx] > > Sent: Friday, August 18, 2017 5:02 PM > > To: Salil Mehta > > Cc: davem@xxxxxxxxxxxxx; Zhuangyuzeng (Yisen); lipeng (Y); > > mehta.salil.lnk@xxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- > > kernel@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Linuxarm > > Subject: Re: [PATCH net-next] net: hns3: Add support to change MTU in > > hardware & netdev > > > > > for example, > > > file: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > > > static int init_one(struct pci_dev *pdev, const struct > pci_device_id > > *ent) > > > > > > netdev->priv_flags |= IFF_UNICAST_FLT; > > > > > > + /* MTU range: 81 - 9600 */ > > > + netdev->min_mtu = 81; > > > + netdev->max_mtu = MAX_MTU; > > > > In this cause, the driver is not using the default values. So it sets > > them. > > > > Anyway, try it. After your alloc_etherdev_mqs(), print the value of > > min_mtu. It should already be set to MIN_ETH_MTU. > I understand your point. In this case, I would like to keep the > range being set by the driver just to be more explicit. > So for now keep this initialization in the driver? Removed the min_mtu initialization from the driver code and added a comment over it to be explicit. Please have a look at the V2 patch. Thanks Salil -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
