Re: [PATCH] i40iw: Fixes for static checker warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2017-07-19 at 13:55 -0500, Shiraz Saleem wrote:
> Remove NULL check for cm_node->listener in i40iw_accept
> as listener is always present at this point.
> 
> Remove the check for cm_node->accept_pend and related code
> in i40iw_cm_event_connected as the cm_node in this context
> is only pertinent to active node and cm_node->accept_pend
> is always 0.
> 
> This fixes the following smatch warnings,
> 
> drivers/infiniband/hw/i40iw/i40iw_cm.c:3691 i40iw_accept()
> error: we previously assumed 'cm_node->listener' could be null
> 
> drivers/infiniband/hw/i40iw/i40iw_cm.c:4061
> i40iw_cm_event_connected()
> error: we previously assumed 'cm_node->listener' could be null
> 
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx>

Thanks, applied.

-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux