On Thu, Aug 17, 2017 at 07:58:07AM -0700, Selvin Xavier wrote:
> ib_get_eth_speed() return 0 on success. Fixing the condition checking
> and prevent reporting failure for query_port verb.
>
> Fixes: d41861942fc5 ("Add generic function to extract IB speed from netdev")
oops
Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
> Signed-off-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>
> ---
> v1 -> v2:
> Fixing the commit log. Also, fixes the same issue in usnic driver also
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 4 ++--
> drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> index d78fedc..3fa20e0 100644
> --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> @@ -264,8 +264,8 @@ int bnxt_re_query_port(struct ib_device *ibdev, u8 port_num,
> * IB stack to avoid race in the NETDEV_UNREG path
> */
> if (test_bit(BNXT_RE_FLAG_IBDEV_REGISTERED, &rdev->flags))
> - if (!ib_get_eth_speed(ibdev, port_num, &port_attr->active_speed,
> - &port_attr->active_width))
> + if (ib_get_eth_speed(ibdev, port_num, &port_attr->active_speed,
> + &port_attr->active_width))
> return -EINVAL;
> return 0;
> }
> diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
> index e5f57dd..97dd79e 100644
> --- a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
> +++ b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
> @@ -309,8 +309,8 @@ int usnic_ib_query_port(struct ib_device *ibdev, u8 port,
> usnic_dbg("\n");
>
> mutex_lock(&us_ibdev->usdev_lock);
> - if (!ib_get_eth_speed(ibdev, port, &props->active_speed,
> - &props->active_width)) {
> + if (ib_get_eth_speed(ibdev, port, &props->active_speed,
> + &props->active_width)) {
> mutex_unlock(&us_ibdev->usdev_lock);
> return -EINVAL;
> }
> --
> 2.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
