On Tue, Aug 15, 2017 at 10:57:37AM -0600, Jason Gunthorpe wrote:
> On Tue, Aug 15, 2017 at 06:58:43PM +0300, Leon Romanovsky wrote:
> > On Tue, Aug 15, 2017 at 09:35:23AM -0600, Jason Gunthorpe wrote:
> > > On Tue, Aug 15, 2017 at 12:56:51PM +0300, Leon Romanovsky wrote:
> > >
> > > > Can it be something like that (untested)?
> > > > #define MODULE_ALIAS_RDMA_NETLINK(_index)
> > >
> > > No, MODULE_ALIAS does something like
> > >
> > > static const char __UNIQUE_ID(name)[]
> > > __used __attribute__((section(".modinfo"), unused, aligned(1))) = __stringify(tag) "=" info;
> > >
> > > So it must accept a string produced by the pre-processor, not by code.
> >
> > But the netlink indexes were defined as anonymous enum, can we safely
> > convert them to be defines?
>
> Technically no, we shouldn't, the difference could break things.. But
> due to the limited use of the header we probably could change to
> defines.
>
> Either way doesn't really matter..
Can this be a solution?
http://elixir.free-electrons.com/linux/latest/source/include/uapi/linux/in.h#L27
Thanks
>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: PGP signature
