On 8/11/2017 6:49 AM, Leon Romanovsky wrote:
From: Leon Romanovsky <leonro@xxxxxxxxxxxx> The functions which are not implemented can be simply ignored instead of defining empty function. This patch removes such functions from hns driver. Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
I thought I replied about this or a very similar patch, but can't find the link. Regardless, I think these sort of work-in-progress stubs are OK as incremental development, part of "showing your work" but I would have expected to see them implemented in the same series, or at least soon there-after. So the fact that these are still empty after this much time. I agree, get rid of them.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html