Hi, I need to top post because comments are unrelated to past discussion. rdma_ah_retrieve_dmac() can never fail for RoCE as its returning pointer from structure ah_attr. Provider driver doesn't need to check for null pointer as ib/core would never call provider if it's not RoCE provider. So this memory leak only exist in theory. When its null, driver should WARN_ON/BUG_ON in extreme case, but that's not necessary either. I have patch is progress under internal review that does nice small cleanup in many provider drivers that eliminates the check completely. Waiting for Moni to finish the review. Parav > -----Original Message----- > From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma- > owner@xxxxxxxxxxxxxxx] On Behalf Of Johannes Thumshirn > Sent: Tuesday, August 08, 2017 7:59 AM > To: Colin Ian King <colin.king@xxxxxxxxxxxxx> > Cc: Lijun Ou <oulijun@xxxxxxxxxx>; Wei Hu <xavier.huwei@xxxxxxxxxx>; > Doug Ledford <dledford@xxxxxxxxxx>; Sean Hefty <sean.hefty@xxxxxxxxx>; > Hal Rosenstock <hal.rosenstock@xxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; > kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] IB/core: fix memory leak on ah on error return path > > On Tue, Aug 08, 2017 at 11:28:16AM +0100, Colin Ian King wrote: > > I was using the same subject start as the patch that introduced the > > memory leak and touched the same portion of code. I can resend if necessary. > > I think having the hns prefix makes it clearer, as the patch doesn't touch IB core > code but hns code. The reference to the patch which introduced the leak is given > byu the fixes line. > > Thanks, > Johannes > > -- > Johannes Thumshirn Storage > jthumshirn@xxxxxxx +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body > of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.ke > rnel.org%2Fmajordomo- > info.html&data=02%7C01%7Cparav%40mellanox.com%7C4b396976866648806 > a1008d4de5d512c%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C63 > 6377939837218186&sdata=l9u%2Bc6N9E31L2I%2BRDBLNh7KuPi%2Fb49yAlbvw > qZvGruk%3D&reserved=0 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
