Re: [PATCH] IB/hns: Explicitly include linux/interrupt.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2017-07-28 at 11:51 +0100, Mark Brown wrote:
> This file uses interrupt APIs but doesn't explicitly include
> linux/interrupt.h meaning that changes in other header files could
> cause
> build breakage as happened in next-20170728 for arm64.  Add an
> explicit
> include to avoid such problems.
> 
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> ---
>  drivers/infiniband/hw/hns/hns_roce_eq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c
> b/drivers/infiniband/hw/hns/hns_roce_eq.c
> index 50f864935a0e..e1e4c16ca3d5 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_eq.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_eq.c
> @@ -30,6 +30,7 @@
>   * SOFTWARE.
>   */
>  
> +#include <linux/interrupt.h>
>  #include <linux/platform_device.h>
>  #include "hns_roce_common.h"
>  #include "hns_roce_device.h"

Hi Mark,

Your patch is fine, but I grabbed the one from Arnd before I grabbed
this one.  That was an accident on my part (yours was sent to the list
first and I normally would have grabbed it), my apologies for that.  I
knew I had seen a patch come through and I scrolled back until I found
it without realizing there were two.

-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux