On Mon, Jul 31, 2017 at 11:24:13AM -0400, Doug Ledford wrote: > On Mon, 2017-07-31 at 10:09 +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > > > The functions ib_register_event_handler() and > > ib_register_event_handler() always returned success and they can't > > fail. > > > > Let's convert those functions to be void and remove redundant checks. > > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > --- > > drivers/infiniband/core/cache.c | 23 ++++++++------- > > -------- > > drivers/infiniband/core/device.c | 8 ++------ > > drivers/infiniband/core/sa_query.c | 3 +-- > > drivers/infiniband/core/uverbs_main.c | 13 +------------ > > drivers/infiniband/ulp/ipoib/ipoib_main.c | 10 +--------- > > drivers/infiniband/ulp/iser/iser_verbs.c | 6 ++---- > > drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c | 7 +------ > > drivers/infiniband/ulp/srpt/ib_srpt.c | 5 ++--- > > include/rdma/ib_verbs.h | 4 ++-- > > 9 files changed, 20 insertions(+), 59 deletions(-) > > Unless this fixes a build warning or an actual bug, this is not -rc > material. You are putting a lot of stuff in -rc pull requests because > "they are simple one line changes" or "it's a cleanup". That's not > what -rc is for. It's for fixes, be they build fixes or run time > fixes. Please split your pull requests appropriately and resubmit. It is not cleanup, but my attempt to run smatch/sparse tools cleanly on drivers/infiniband. I'll resubmit. Thanks > > -- > Doug Ledford <dledford@xxxxxxxxxx> > GPG KeyID: B826A3330E572FDD > Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD >
Attachment:
signature.asc
Description: PGP signature
