On Mon, Jul 31, 2017 at 09:03:12AM -0400, Dennis Dalessandro wrote: > On 7/31/2017 3:09 AM, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > > > The functions ib_register_event_handler() and > > ib_register_event_handler() always returned success and they can't fail. > > > > Let's convert those functions to be void and remove redundant checks. > > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > --- > > drivers/infiniband/core/cache.c | 23 ++++++++--------------- > > drivers/infiniband/core/device.c | 8 ++------ > > drivers/infiniband/core/sa_query.c | 3 +-- > > drivers/infiniband/core/uverbs_main.c | 13 +------------ > > drivers/infiniband/ulp/ipoib/ipoib_main.c | 10 +--------- > > drivers/infiniband/ulp/iser/iser_verbs.c | 6 ++---- > > drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c | 7 +------ > > drivers/infiniband/ulp/srpt/ib_srpt.c | 5 ++--- > > include/rdma/ib_verbs.h | 4 ++-- > > 9 files changed, 20 insertions(+), 59 deletions(-) > > I think you mean "... and ib_unregister_event_handler()". Also maybe mention > a couple words about this lets us clean up some of the goto stuff. Right, I'll respin. > > Otherwise: > > Reviewed-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> Thanks
Attachment:
signature.asc
Description: PGP signature
