Re: [PATCH rdma-core 3/8] srp_daemon: Add a --systemd option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 28, 2017 at 12:35:07PM +0200, Benjamin Drung wrote:
> Am Donnerstag, den 27.07.2017, 10:48 -0600 schrieb Jason Gunthorpe:
> > On Thu, Jul 27, 2017 at 04:12:29PM +0200, Benjamin Drung wrote:
> > > Am Mittwoch, den 26.07.2017, 13:59 -0600 schrieb Jason Gunthorpe:
> > > > This changes how logging is setup to send log messages only to
> > > > syslog,
> > > > instead of to stderr and to syslog. If messages are sent to both
> > > > places then systemd will create duplicate log entries.
> > > 
> > > The parameter name --systemd is not a good choice. It doesn't tell
> > > me what will change ("Enable systemd integration" does not help
> > > here) and someone might to want to use the switch without
> > > systemd. So something like --no-log-to-stderr or --syslog-only
> > > would
> > > better describe the behavior.
> > 
> > There are more systemd integration features to come, eg sd_notify,
> > some journal integration is possible.
> > 
> > I don't want to keep adding options along these lines, universally
> > having --systemd to turn everything we want to do on makes sense.
> 
> A more flexible approach: Add individual parameters and let the
> say: "--systemd is equivalent to --foo --bar --baz"

Why would someone want to turn on something like sd_notify
individually? Or journal metadata logging? It seems purposeless..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux