On Mon, Jul 24, 2017 at 04:26:41PM -0600, Jason Gunthorpe wrote: > This provides the necessary infrastructure for the kernel to automatically > load RDMA associated netlink modules when users space sends messages to them. > > This is at least enough support for the kernel to autoload everything required > for iwpmd to run. > > Jason Gunthorpe (3): > rdma: Allow demand loading of NETLINK_RDMA > rdma: Autoload netlink client modules > iwpmd: Suppress expected kernel message > > drivers/infiniband/core/cma.c | 2 + > drivers/infiniband/core/device.c | 2 + > drivers/infiniband/core/iwcm.c | 9 ++++ > drivers/infiniband/core/netlink.c | 99 +++++++++++++++++++++++---------------- > include/rdma/rdma_netlink.h | 12 +++++ > 5 files changed, 83 insertions(+), 41 deletions(-) There are number of reasons why I don't really like this series. First, it interferes badly with my RDMA netlink series posted here in previous cycle and I'm expecting to see it in, so I can move forward with RDMAtool implementation. Second, from brief review, it is unclear to me, how do you protect autoload caused by regular user who sends netlink message to ib_core. Third, it is ib_core who should autoload modules by default, and not some random daemon in user space. My 2-cents. > > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: PGP signature
