Re: [PATCH for-next 1/2] IB/rdmavt: Setting of QP timeout can overflow jiffies computation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/17/2017 1:37 PM, Dennis Dalessandro wrote:
> From: Kaike Wan <kaike.wan@xxxxxxxxx>
> 
> Current computation of qp->timeout_jiffies in rvt_modify_qp() will cause
> overflow due to the fact that the input to the function usecs_to_jiffies
> is only 32-bit ( unsigned int). Overflow will occur when attr->timeout is
> equal to or greater than 30. The consequence is unnecessarily excessive
> retry and thus degradation of the system performance.
> 
> This patch fixes the problem by limiting the input to 5-bit and calling
> usecs_to_jiffies() before multiplying the scaling factor.
> 
> Reviewed-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>
> Signed-off-by: Kaike Wan <kaike.wan@xxxxxxxxx>
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>

This was accepted into 4.13-rc, thanks.

-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG Key ID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux