On Tue, 2017-06-27 at 12:19 +0300, Sagi Grimberg wrote:
> From: Vijay Immanuel <vijayi@xxxxxxxxxxxxxxxxx>
>
> If we modified the qp to ERROR state, and
> drained the recieve queue, post_recv must
^^^^^^^
receive?
> trigger the responder task to complete
> the drain work request.
>
> Cc: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> Signed-off-by: Vijay Immanuel <vijayi@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
> ---
> drivers/infiniband/sw/rxe/rxe_resp.c | 3 +++
> drivers/infiniband/sw/rxe/rxe_verbs.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c
> index 23039768f541..f66b48c114ac 100644
> --- a/drivers/infiniband/sw/rxe/rxe_resp.c
> +++ b/drivers/infiniband/sw/rxe/rxe_resp.c
> @@ -1217,6 +1217,9 @@ void rxe_drain_req_pkts(struct rxe_qp *qp, bool notify)
> kfree_skb(skb);
> }
>
> + if (notify)
> + return;
> +
> while (!qp->srq && qp->rq.queue && queue_head(qp->rq.queue))
> advance_consumer(qp->rq.queue);
Since an "if (...) return" statement is added, please consider moving the
qp->srq test out of the while-loop and into the if-expression. Anyway:
Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxx>--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
