Re: [PATCH] RDMA/bnxt_re: checking for NULL instead of IS_ERR()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>

Thanks

On Mon, Jul 10, 2017 at 12:52 PM, Dan Carpenter
<dan.carpenter@xxxxxxxxxx> wrote:
> bnxt_re_alloc_mw() doesn't return NULL, it returns error pointers.
>
> Fixes: 9152e0b722b2 ("RDMA/bnxt_re: HW workarounds for handling specific conditions")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> index c7bd68311d0c..e794b0fa4ae6 100644
> --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> @@ -588,10 +588,10 @@ static int bnxt_re_create_fence_mr(struct bnxt_re_pd *pd)
>
>         /* Create a fence MW only for kernel consumers */
>         mw = bnxt_re_alloc_mw(&pd->ib_pd, IB_MW_TYPE_1, NULL);
> -       if (!mw) {
> +       if (IS_ERR(mw)) {
>                 dev_err(rdev_to_dev(rdev),
>                         "Failed to create fence-MW for PD: %p\n", pd);
> -               rc = -EINVAL;
> +               rc = PTR_ERR(mw);
>                 goto fail;
>         }
>         fence->mw = mw;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux