On Wed, Jun 28, 2017 at 11:10 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > With the introduction of mlx5 firmware flash support, we get a link > error with CONFIG_MLXFW=m and CONFIG_MLX5_CORE=y: > > drivers/net/ethernet/mellanox/mlx5/core/fw.o: In function `mlx5_firmware_flash': > fw.c:(.text+0x9d4): undefined reference to `mlxfw_firmware_flash' Thanks Arnd, I got a report on that from Jakub but you were before me here.. > We could have a more elaborate method to force MLX5 to be a loadable > module in this case, but the easiest fix seems to be to always enable > MLXFW as well, like we do for CONFIG_MLXSW_SPECTRUM, which is the other > user of mlxfw_firmware_flash. We would not want to force mlx5 users to build mlxfw. So lets either use the more elaborate method or maybe instead of using IS_ENABLED in mlxfw.h use IS_REACHABLE (this was suggested by Jakub) Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
