Re: [PATCH] ib_core: Enable and expose force_mr module parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




I hope that we are done.
https://patchwork.kernel.org/patch/9808615/

You have a bogus empty line change there.

If I remember correctly, It was needed to silence checkpatch.

So it should not be a part of the patch.

Also, I think that the statement is _really_ unnecessary:

"* Setting it to "true" will allow to mimic with IB devices,
 * the slow memory registration of iWARP devices."

And, its simply not true. Its designed to test the rw logic for
sg patterns that would normally not be registered. The fact
that iWARP registers memory for rdma reads is completely orthogonal.

And this statement is not true either:

"* This parameter is useful for new ULP bringup
 * and/or conversion to this R/W API."

Its designed to test the code itself, not for ULP
bringup or conversion, although it is useful for that.

And, I can't say that I 100% agree with not making it
configurable, but since you insist so much, at least
give a proper description.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux