On Tue, Jun 27, 2017 at 04:04:49PM -0700, Stephen Hemminger wrote: > On Tue, 27 Jun 2017 17:39:17 +0300 > Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > > +static const char *dev_caps[64] = { > > + "RESIZE_MAX_WR", > > + "BAD_PKEY_CNTR", > > + "BAD_QKEY_CNTR", > > + "RAW_MULTI", > > + "AUTO_PATH_MIG", > > + "CHANGE_PHY_PORT", > > + "UD_AV_PORT_ENFORCE", > > + "CURR_QP_STATE_MOD", > > + "SHUTDOWN_PORT", > > + "INIT_TYPE", > > + "PORT_ACTIVE_EVENT", > > + "SYS_IMAGE_GUID", > > + "RC_RNR_NAK_GEN", > > + "SRQ_RESIZE", > > + "N_NOTIFY_CQ", > > + "LOCAL_DMA_LKEY", > > + "RESERVED", > > + "MEM_WINDOW", > > + "UD_IP_CSUM", > > + "UD_TSO", > > + "XRC", > > + "MEM_MGT_EXTENSIONS", > > + "BLOCK_MULTICAST_LOOPBACK", > > + "MEM_WINDOW_TYPE_2A", > > + "MEM_WINDOW_TYPE_2B", > > + "RC_IP_CSUM", > > + "RAW_IP_CSUM", > > + "CROSS_CHANNEL", > > + "MANAGED_FLOW_STEERING", > > + "SIGNATURE_HANDOVER", > > + "ON_DEMAND_PAGING", > > + "SG_GAPS_REG", > > + "VIRTUAL_FUNCTION", > > + "RAW_SCATTER_FCS", > > + "RDMA_NETDEV_OPA_VNIC", > > +}; > > Please use array initializer so that header and capabilities don't get different values. > Are the bit values in some rdma header file? It is enum ib_device_cap_flags copied from include/rdma/ib_verbs.h. These enum ib_device_cap_flags and enum ib_port_cap_flags are not exposed to the user (include/uapi/rdma/*) and I'm planning to move them there in next cycle. Thanks
Attachment:
signature.asc
Description: PGP signature