On Mon, Jun 26, 2017 at 01:38:52PM +0300, Yuval Shaia wrote: > On Mon, Jun 26, 2017 at 01:02:31PM +0300, Leon Romanovsky wrote: > > On Mon, Jun 26, 2017 at 11:53:13AM +0300, Yuval Shaia wrote: > > > No reason to have dependency on PCI for the entire infiniband stack so > > > move it to KConfig of only the drivers that actually using PCI. > > > > > > Signed-off-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx> > > > --- > > > drivers/infiniband/Kconfig | 1 - > > > drivers/infiniband/hw/cxgb3/Kconfig | 1 + > > > drivers/infiniband/hw/cxgb4/Kconfig | 1 + > > > drivers/infiniband/hw/hfi1/Kconfig | 1 + > > > drivers/infiniband/hw/i40iw/Kconfig | 1 + > > > drivers/infiniband/hw/qedr/Kconfig | 1 + > > > drivers/infiniband/hw/qib/Kconfig | 1 + > > > drivers/infiniband/sw/rdmavt/Kconfig | 1 + > > > > Why do you need PCI for rdmavt? > > Saw calls such as get_pci_dev so just suspect, but you are right, i don't > see why SW device needs PCI. > > > > > > drivers/infiniband/ulp/ipoib/Kconfig | 1 + > > > 9 files changed, 8 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig > > > index 234fe01..568088a 100644 > > > --- a/drivers/infiniband/Kconfig > > > +++ b/drivers/infiniband/Kconfig > > > @@ -1,6 +1,5 @@ > > > menuconfig INFINIBAND > > > tristate "InfiniBand support" > > > - depends on PCI || BROKEN > > > > By the way, do you know why are we dependent on BROKEN? > > No, assume that it is like if PCI is not defined the "break" configuration > or something like that. > Will be happy if you can shad some light on that. I don't know too, it was set more than 10 years ago. I doubt if it is relevant nowadays. Thanks > > > > > Thanks > >
Attachment:
signature.asc
Description: PGP signature
