On Wed, Jun 21, 2017 at 04:18:54PM +0000, Tung, Chien Tin wrote: > > From: Jason Gunthorpe [mailto:jgunthorpe@xxxxxxxxxxxxxxxxxxxx] > > Sent: Wednesday, June 21, 2017 11:12 AM > > To: Leon Romanovsky <leon@xxxxxxxxxx> > > Cc: Doug Ledford <dledford@xxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; Tung, > > Chien Tin <chien.tin.tung@xxxxxxxxx>; Steve Wise > > <swise@xxxxxxxxxxxxxxxxxxxxx>; Stephen Hemminger > > <stephen@xxxxxxxxxxxxxxxxxx>; Jiri Pirko <jiri@xxxxxxxxxxxx>; Ariel Almog > > <ariela@xxxxxxxxxxxx>; Linux Netdev <netdev@xxxxxxxxxxxxxxx>; Leon > > Romanovsky <leonro@xxxxxxxxxxxx> > > Subject: Re: [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device > > definitions to UAPI > > > > On Wed, Jun 21, 2017 at 09:05:22AM +0300, Leon Romanovsky wrote: > > > RDMA_NL_IWCM, > > > RDMA_NL_RSVD, > > > RDMA_NL_LS, /* RDMA Local Services */ > > > + /* > > > + * RDMA_NL_I40IW not in use and it was added here by mistake, > > > + * but we need to keep it anyway, because it is UAPI and for > > > + * unknown reasons, someone in the field decided to replace "5" > > > + * with this define. > > > + */ > > > RDMA_NL_I40IW, > > > > Since this doesn't do anything, never did anything, I think you should just > > delete it. Anything in userspace that refers to this name is unconditionally > > broken and a compile failure is the better choice. > > > > Jason > > I agree. Please delete RDMA_NL_I40IW. Fixed and Steve's comments too. Thanks > > Chien
Attachment:
signature.asc
Description: PGP signature
