From: Yuval Mintz <Yuval.Mintz@xxxxxxxxxx> Date: Sun, 18 Jun 2017 14:50:28 +0300 > Changes from previous versions > ------------------------------ > - V2: Add several inclusion into qede_rdma.h to have proper declarations > of all variable types used in it I'm still not happy at all. You failed the address the specific thing I asked to be fixed. In patch #4, the rename, you just say in your commit message that you are "renaming". But in the qedr/main.c part of the change, you are _REMOVING_ the include. And I said that can't be right if all you are doing is renaming the files. So either fix that part of the change to actually rename the include header, rather than removing the include, or explain _IN DETAIL_ in the commit log message why removing it is the right thing to do and especially _WHY_ it is appropriate for it to be done as part of the renaming patch. Can you understand how inconsistent it is to have a patch that says nothing more than "I'm renaming files" and yet have other stuff happening? THanks. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
