From: "Mintz, Yuval" <Yuval.Mintz@xxxxxxxxxx> Date: Fri, 16 Jun 2017 12:41:15 +0000 >> In file included from drivers/net//ethernet/qlogic/qede/qede.h:43:0, >> from drivers/net//ethernet/qlogic/qede/qede_ptp.h:38, >> from drivers/net//ethernet/qlogic/qede/qede_fp.c:43: >> >> include/linux/qed/qede_rdma.h:57:12: warning: 'struct pci_dev' declared >> inside parameter list [enabled by default] >> >> include/linux/qed/qede_rdma.h:57:12: warning: its scope is only this >> definition or declaration, which is probably not what you want [enabled by >> default] > > This patch is merely renaming qede_roce.h -> qede_rdma.h. > I guess the kbuild test robot got better scripts than the time we've added qede_rdma.h, > or else it would have catched the fact there are no inclusion since then. > > Dave - given this is an existing warning exposed due to a rename [and not something > that actually got introduced in this patch], do you want us to fix it via v2 of this series? > Or send a fix for it later? I don't know, look at what you're doing in main.c, you're removing an include rather than changing the name of the file being included. That is not a zero-change rename at all. Please respin this and fix all of the things the build bot is reporting as well as what I just mentioned. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
