> > > >> +enum uverbs_attr_spec_flags { > > > >> + UVERBS_ATTR_SPEC_F_MANDATORY = 1U << 0, > > > >> + /* Support extending attributes by length */ > > > >> + UVERBS_ATTR_SPEC_F_MIN_SZ = 1U << 1, > > > >> +}; > > > > > > > > Don't use named enums for bit flags. The result of ORing flags > ends > > > up as a non-enum value. > > > > > > > > > > Sure > > Isn't this common place in the kernel now? The enum should be > anonymous for this usage though. I wasn't clear. Using an anonymous enum was what I was getting at. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html