Re: [RFC 2/5] verbs: Introduce tag matching SRQ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 13/06/2017 00:18, Jason Gunthorpe wrote:
On Tue, Jun 13, 2017 at 12:09:29AM +0300, Artemy Kovalyov wrote:


On 12/06/2017 23:50, Jason Gunthorpe wrote:
On Mon, Jun 12, 2017 at 11:38:09PM +0300, Artemy Kovalyov wrote:


On 12/06/2017 19:38, Jason Gunthorpe wrote:
On Mon, Jun 12, 2017 at 09:42:44AM +0300, Artemy Kovalyov wrote:
enum ibv_srq_type {
	IBV_SRQT_BASIC,
-	IBV_SRQT_XRC
+	IBV_SRQT_XRC,
+	IBV_SRQT_TAG_MATCHING
};

Please put trailing commas on all these enum changes in all patches

So do we drop overboard all -Wpedantic users?

Eh? Try it.

You only get warnings if your compiler is running in c89 or ansi mode,
which went 'overboard' a long time ago.
Bare -Wpedantic -Werror fails with this.

You need -std=c99 on older compilers.

That was my point - implying new standards' ubiquity we narrowing compatibility. I not insist, just want to clarify whether this code standard was chosen for the project.


Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux