On Mon, Jun 05, 2017 at 06:04:18PM +0300, Moni Shoua wrote: > > > > In this case i have two questions. > > - rxe_query_port translates speeds to ib_speed by range where > > __to_ib_speed_width translates by fixed speeds. Which one is correct? > it depends. If lksettings.base.speed is an enum value of any value. > only one can be true > > - rxe_query_port fallback to get_settings where __to_ib_speed_width just > > take default if get_link_ksettings is not implemented. Which one is correct? > In this case I would go for rxe implementation. > > Ok, i will do my best to merge the two functions correctly. In addition to the above two questions (and thanks for your quick response), i've noticed some conflicts in how bnxt translate to IB speed and how rxe does. For example bnxt.10000=QDR while rxe.10000=FDR10 so will appreciate a careful review here. > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
